Skip to content

fix(material-experimental/mdc-dialog): remove extra outline in high contrast mode #24140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(material-experimental/mdc-dialog): remove extra outline in high contrast mode #24140

merged 1 commit into from
Jan 7, 2022

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 28, 2021

MDC have started including their own border in high contrast mode so our outline isn't necessary anymore.

@crisbeto
fix(material-experimental/mdc-dialog): remove extra outline in high c…
379c279 
…ontrast mode

MDC have started including their own `border` in high contrast mode so our `outline` isn't necessary anymore.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 28, 2021
@crisbeto crisbeto requested a review from devversion December 28, 2021 08:53
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@wagnermaciel wagnermaciel merged commit 3f727a2 into angular:master Jan 7, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 7, 2022
@crisbeto @wagnermaciel
fix(material-experimental/mdc-dialog): remove extra outline in high c…
2f66888 
…ontrast mode (#24140)

MDC have started including their own `border` in high contrast mode so our `outline` isn't necessary anymore.

(cherry picked from commit 3f727a2)
zarend pushed a commit to zarend/components that referenced this pull request Jan 7, 2022
@crisbeto @zarend
fix(material-experimental/mdc-dialog): remove extra outline in high c…
a89bfc8 
…ontrast mode (angular#24140)

MDC have started including their own `border` in high contrast mode so our `outline` isn't necessary anymore.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 7, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @devversion @googlebot @wagnermaciel